Review Request: Twitter OAuth support for microblog dataengine

Discussion:

Ryan Bitanga

2010-06-22 11:47:11 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4440/
-----------------------------------------------------------

(Updated 2010-06-22 11:47:11.665544)

Review request for Plasma.

Summary
-------

This patch adds oauth support for the microblog dataengine when used with twitter. No changes need to be made to the applet.

Helper functions for signature generation and conversion of http request parameters to strings were based on qoauth by Dominik Kapusta.

This addresses bug 242048.
https://bugs.kde.org/show_bug.cgi?id=242048

Diffs
-----

/trunk/KDE/kdeplasma-addons/dataengines/microblog/CMakeLists.txt 1141257
/trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.h PRE-CREATION
/trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.cpp PRE-CREATION
/trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.h 1141257
/trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.cpp 1141257

Diff: http://reviewboard.kde.org/r/4440/diff

Testing
-------

Thanks,

Ryan

Ryan Bitanga

2010-06-22 11:33:28 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4440/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

This patch adds oauth support for the microblog dataengine when used with twitter. No changes need to be made to the applet.

Helper functions for signature generation and conversion of http request parameters to strings were based on qoauth by Dominik Kapusta.

Diffs
-----

/trunk/KDE/kdeplasma-addons/dataengines/microblog/CMakeLists.txt 1141257
/trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.h PRE-CREATION
/trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.cpp PRE-CREATION
/trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.h 1141257
/trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.cpp 1141257

Diff: http://reviewboard.kde.org/r/4440/diff

Testing
-------

Thanks,

Ryan

Sebastian Kügler

2010-06-23 10:39:40 UTC

Permalink

Post by Ryan Bitanga
This patch adds oauth support for the microblog dataengine when used with
twitter. No changes need to be made to the applet.
Helper functions for signature generation and conversion of http request
parameters to strings were based on qoauth by Dominik Kapusta.

Looks like a candidate for backporting to 4.4 as well, no?

--
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

Marco Martin

2010-06-22 12:16:23 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4440/#review6230
-----------------------------------------------------------

Ship it!

even if it can be seen as a feature it's pretty important that goes in asap, before 4.5
btw, looking at the patch they shouldn't, but did you see if doesn't interfere with identica?

- Marco

Post by Ryan Bitanga
-----------------------------------------------------------
http://reviewboard.kde.org/r/4440/
-----------------------------------------------------------
(Updated 2010-06-22 11:47:11)
Review request for Plasma.
Summary
-------
This patch adds oauth support for the microblog dataengine when used with twitter. No changes need to be made to the applet.
Helper functions for signature generation and conversion of http request parameters to strings were based on qoauth by Dominik Kapusta.
This addresses bug 242048.
https://bugs.kde.org/show_bug.cgi?id=242048
Diffs
-----
/trunk/KDE/kdeplasma-addons/dataengines/microblog/CMakeLists.txt 1141257
/trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.h PRE-CREATION
/trunk/KDE/kdeplasma-addons/dataengines/microblog/oauth.cpp PRE-CREATION
/trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.h 1141257
/trunk/KDE/kdeplasma-addons/dataengines/microblog/timelinesource.cpp 1141257
Diff: http://reviewboard.kde.org/r/4440/diff
Testing
-------
Thanks,
Ryan

Ryan Bitanga

2010-06-22 16:27:49 UTC

Permalink

Post by Ryan Bitanga

Post by Marco Martin
even if it can be seen as a feature it's pretty important that goes in asap, before 4.5
btw, looking at the patch they shouldn't, but did you see if doesn't interfere with identica?

I look at it as more of a bugfix than a feature. Tested it and it doesn't interfere with identica

- Ryan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4440/#review6230
-----------------------------------------------------------